Fix RM pro temperature sensor#50098
Merged
MartinHjelmare merged 5 commits intohome-assistant:devfrom May 7, 2021
Merged
Conversation
|
Hey there @Danielhiversen, mind taking a look at this pull request as its been labeled with an integration ( |
janiversen
reviewed
May 5, 2021
janiversen
approved these changes
May 6, 2021
Member
|
Thanks for adding the test. The new function "normalised" makes it real easy understand how you "overwrite" the faulty temperature. |
Contributor
Author
|
Thank you! |
Member
|
Should we tag this for a patch release? |
Member
|
Looks very localized, lets add it to help some people out. |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
RM pro has a firmware issue that causes it to return -7 ºC when we call check_sensors() around 22.9 and 23 ºC.
If we ignore the issue, we return unreliable data. If we add a conditional and raise an exception, we raise false positives (-7 ºC may be a valid temperature), and it would also flood the logs, this behavior is consistent.
The right place to fix this is the firmware, but we don't have access to it.
Proposed change
Add a conditional to the update manager and replace -7 with the previous temperature when the variation is bigger than 3 °C.
If we get -7 °C at startup, we return None, so the temperature will be unknown until we get a different value, from which it will be possible to determine whether the next -7 is valid or not.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: